Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf52: reset UARTE peripheral in serial_free #11790

Merged
merged 1 commit into from Nov 14, 2019
Merged

nrf52: reset UARTE peripheral in serial_free #11790

merged 1 commit into from Nov 14, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Oct 31, 2019 •
edited

Description (required)

Resolves: #11758

Taken from #11779, thanks @RobVlaar

Summary of change (What the change is for and why)

Add workaround to reset the UARTE peripheral on a destruction of SerialBase to be able to go into deep sleep.

Documentation (Details of any document updates required)

Pull request type (required)

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@desmond-blue @RobVlaar

Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@0xc0170 0xc0170 changed the title Workaround to reset UARTE peripheral to be able to go into deep sleep nrf52: reset UARTE peripheral to be able to go into deep sleep Oct 31, 2019
@0xc0170 0xc0170 mentioned this pull request Oct 31, 2019
Closed
@ciarmcom ciarmcom requested review from desmond-blue and a team October 31, 2019 16:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@desmond-blue @ARMmbed/mbed-os-maintainers please review.

@kjbracey
Copy link
Contributor

kjbracey commented Nov 1, 2019 •
edited

This doesn't match the description.

serial_free isn't being called from the destructor, so I guess this allows reduced power only via enable_input/output?

I still think serial_free should be added to the destructor, but can be a separate task.

@RobVlaar
Copy link

RobVlaar commented Nov 1, 2019 •
edited

@0xc0170 can you change this in SerialBase.cpp on line 276
@kjbracey-arm like this ?

SerialBase::~SerialBase()
{
    // No lock needed in destructor

    // Detaching interrupts releases the sleep lock if it was locked
    for (int irq = 0; irq < IrqCnt; irq++) {
        attach(NULL, (IrqType)irq);
    }
    
    if(_rx_enabled || _tx_enabled))
    {  
        serial_free(&_serial);
    }
}

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 5, 2019 •
edited

I still think serial_free should be added to the destructor, but can be a separate task.

Yes, we should do it. I thought it was in PR or already on master so I took only nrf changes here

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 5, 2019

@kjbracey-arm shall I add the suggestion to a new PR?

@0xc0170 0xc0170 changed the title nrf52: reset UARTE peripheral to be able to go into deep sleep nrf52: reset UARTE peripheral in serial_free Nov 12, 2019
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 12, 2019

I fixed the title, this is just fixing nrf52 serial_free implementation.

@kjbracey-arm please review

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 13, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 6993724 into ARMmbed:master Nov 14, 2019
@0xc0170 0xc0170 removed the needs: CI label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desmond-blue desmond-blue desmond-blue approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using rawSerial adds about 600µA
6 participants
@0xc0170 @ciarmcom @kjbracey @RobVlaar @mbed-ci @desmond-blue